also, shaman build (at least, haven’t checked others) added a point is now 19,19,20

// tree count order by wowhead order
$tree_counts = array(
array(20, 22, 21), // druid
array(19, 19, 20), // hunter
array(21, 21, 19), // mage
array(20, 20, 20), // paladin
array(21, 20, 21), // priest
array(19, 19, 19), // rogue
array(19, 19, 19), // shaman
array(18, 19, 19), // warlock
array(20, 21, 20), // warrior
array(20, 20, 19) // death knight
);


Regards,
Lockslap

In the new version of the function ill add a check to make sure the provided string is the correct length for that character

$return .= (strlen($b)==strlen($cur_tree))? $pre_return: $pre_return.$none;

The problem here is that the wowhead links encode 1 character for every 2 lines, so if the blizzard string uses 29 of the 30 allotted characters it will fill the full 15 lines of the wowhead string and not require a Z terminator. However because your check for the Z terminator uses the blizzard string, it will incorrectly use a Z terminator whenever the only right-trimmed zero is in the last space. I have a correction here:

$return .= (strlen($pre_return) == ceil($trees[$class][$tree_index] / 2)) ? $pre_return : $pre_return . $none;

This checks the length of the wowhead encoded string for the Z terminator, which fixed my issue and should work correctly. I haven’t tested this against a tree with an odd number of characters in the blizzard string since all mage trees contain an even number, but I’m pretty sure ceil() will come up with the correct result for odd-numbered trees. Let me know if that works!

I might have a bit of a poke around and see if I can see what they are doing. I can’t imagine they’ve moved far away from the algorithm you present here.